search

localgovdrupal / localgov_step_by_step

Implemention of the Gov.uk Step by step navigation journeys for LocalGovDrupal
GNU General Public License v2.0
1 stars 1 forks source link

Fix issue with accessible label #105

Closed chriswales95 closed 1 month ago

chriswales95 commented 2 months ago

What does this change?

It changes the aria-label to use the same text of the button at the start of the label to satisfy the WCAG requirements.

How to test

Use something like Siteimprove and should no longer flag the isue.

How can we measure success?

Clients should see less errors reported by tools like Siteimprove for this particular issue.

Have we considered potential risks?

There should be no additional risks than before.

Images

Before: Screenshot 2024-08-20 at 12 03 59

After: Screenshot 2024-08-20 at 12 17 44

Accessibility

finnlewis commented 2 months ago

@msayoung could we get your thoughts on this one?

chriswales95 commented 2 months ago

Relates to #104

chriswales95 commented 2 months ago

Just realised @msayoung has their own issue for this and my issue was uneeded. It is here: https://github.com/localgovdrupal/localgov_step_by_step/issues/66