Open keelanfh opened 1 year ago
Possible duplicate of #26?
Possibly... that refers to subsite pages, whereas this is subsite overviews. The banner mentioned there could be a solution for subsite overviews too, but I don't know enough about this functionality really.
It could just be me but none of the Subsites Overviews seems have an h1? Eg: https://test.localgovdrupal.org/fostering https://test.localgovdrupal.org//test-subsite-demo-all-components
Withh reference to https://github.com/localgovdrupal/localgov_subsites/issues/26 neither do the Subsites pages as far as I can see?
The h1 is provided by the banner paragraph, I suggest some default if a banner paragraph isn't present so the page title renders.
Out of the box the banner titles aren't H1s unfortunately. See the demo site: https://demo.localgovdrupal.org/fostering
We also have two banner types, one has a title field and the other not. Neither are required.
So two issues to solve
Another option would be to always have the page title as H1 , and / or add a visually-hidden class to it when there is a primary banner to visually hide it. Thoughts?
Do we mind that the page title and the h1 may be different?
Perhaps we should ask some content creators which option they would prefer? To me, it sounds like the second option outlined by @msayoung offers more certainty to those charged with creating content using this feature. It means they can decide whether or not to have a primary banner on design grounds without needing to worry about what is going to render as the H1. Just my two cents....
@andybroomfield Can you give me a couple of examples of where you are using subsites at B&H ?
e.g. https://demo.localgovdrupal.org/fostering
Perhaps the title should be marked
h1
?