search

localgovdrupal / localgov_subsites

Replaces LocalGov Campaigns with a new name and extended functionality to support subsites within LocalGov Drupal installations.
GNU General Public License v2.0
4 stars 2 forks source link

Strict types support #144

Closed millnut closed 2 months ago

millnut commented 5 months ago

With Drupal core moving towards strict types, more info I've added a test pipeline in preparation https://github.com/localgovdrupal/localgov_project/pull/153 which has highlighted some failures which we should fix.

 ------ -------------------------------------------------------------- 
  Line   modules/contrib/localgov_subsites/localgov_subsites.module    
 ------ -------------------------------------------------------------- 
  132    Call to function in_array() requires parameter #3 to be set.  
 ------ -------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------- 
  Line   modules/contrib/localgov_subsites/src/Plugin/Block/SubsitesHierarchyTrait.php  
         (in context of class                                                           
         Drupal\localgov_subsites\Plugin\Block\SubsitesAbstractBlockBase)               
 ------ ------------------------------------------------------------------------------- 
  113    Call to function in_array() requires parameter #3 to be set.                   
 ------ ------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------- 
  Line   modules/contrib/localgov_subsites/src/Plugin/Block/SubsitesHierarchyTrait.php  
         (in context of class Drupal\localgov_subsites\Subsite)                         
 ------ ------------------------------------------------------------------------------- 
  113    Call to function in_array() requires parameter #3 to be set.                   
 ------ ------------------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------------- 
  Line   modules/contrib/localgov_subsites/src/Plugin/Block/SubsitesNavigationBlock.php  
 ------ -------------------------------------------------------------------------------- 
  126    Call to function in_array() requires parameter #3 to be set.                    
 ------ --------------------------------------------------------------------------------