search

localgovdrupal / localgov_subsites

Replaces LocalGov Campaigns with a new name and extended functionality to support subsites within LocalGov Drupal installations.
GNU General Public License v2.0
4 stars 2 forks source link

Moved localgov_subsites_paragraphs module to localgov_paragraphs #95

Closed stephen-cox closed 2 years ago

stephen-cox commented 2 years ago

Part of #91

To test this you can do the following:

composer require localgovdrupal/localgov_paragraphs:"dev-feature/58-move-subsite-paragraphs as 2.1.0"
composer require localgovdrupal/localgov_subsites:"dev-feature/91-move-paragraphs as 2.1.0"
stephen-cox commented 2 years ago

Tests are failing until https://github.com/localgovdrupal/localgov_paragraphs/pull/59 is merged and we have a 2.1.0 release of paragraphs

ekes commented 2 years ago

The update of requirement feels like this should be safe. I'm still a bit concerned about how it'll play on an existing site. Have we got a test on an existing site updating, preferably with APCu on (actually there's no classes involved not a problem)?

stephen-cox commented 2 years ago

Tested locally with demo content. Just tested this on https://test.localgovdrupal.org/ as well. If there are concerns about this we can ask someone with a live site to test it

ekes commented 2 years ago

As it's not got any oo code I think it's fine actually; but can check with others on MM.