Open rupertj opened 2 months ago
Discussing briefly in Merge Tuesday, sounds like a bit more testing might be needed before approving. I'll try to test soon.
I haven't had chance to test this yet but can you change a line in walkMenuTree like this:
return $parentNode ? $this->walkMenuTree($parentNode) : NULL;
This should prevent an error if a node has a menu parent that is not a node, e.g. events below the listing page.
I haven't had chance to test this yet but can you change a line in walkMenuTree like this: ...
Good spot. I've added that.
Let's get this merged as soon as possible, it looks like a really good feature to have.
@rupertj can you get the merge conflict sorted, and then @Polynya can you get it tested again?
Great work team!
Thanks @rupertj
@Polynya over to you to test again if you can please?
Implements #2