search

localgovdrupal / localgov_subsites_extras

GNU General Public License v2.0
0 stars 0 forks source link

Multi page types #16

Open rupertj opened 2 months ago

rupertj commented 2 months ago

Implements #2

finnlewis commented 2 months ago

Discussing briefly in Merge Tuesday, sounds like a bit more testing might be needed before approving. I'll try to test soon.

Polynya commented 2 months ago

I haven't had chance to test this yet but can you change a line in walkMenuTree like this:

return $parentNode ? $this->walkMenuTree($parentNode) : NULL;

This should prevent an error if a node has a menu parent that is not a node, e.g. events below the listing page.

See https://github.com/localgovdrupal/localgov_subsites_extras/pull/14/files#diff-0bc0657a906fb9cf8b5668cf07d0fc36e4c3fa1a8dabece778c28fffd53d3335R113

rupertj commented 2 months ago

I haven't had chance to test this yet but can you change a line in walkMenuTree like this: ...

Good spot. I've added that.

markconroy commented 1 month ago

Let's get this merged as soon as possible, it looks like a really good feature to have.

@rupertj can you get the merge conflict sorted, and then @Polynya can you get it tested again?

Great work team!

markconroy commented 1 month ago

Thanks @rupertj

@Polynya over to you to test again if you can please?