search

localgovdrupal / localgov_subsites_extras

GNU General Public License v2.0
0 stars 0 forks source link

subsites extas should have a requirement for subsites #25

Closed markconroy closed 1 month ago

markconroy commented 1 month ago

At the moment it's possible to install Subsites Extras module on its own, without the subsites module. But then it will do nothing.

It should have subsites as a dependency.

rupertj commented 1 month ago

This is a won't fix for me, as you don't actually need subsites to use subsites_extras.

markconroy commented 1 month ago

Mind ... blown ... 🤯

Thanks Ru!

rupertj commented 1 month ago

To explain this better :)

subsites_extras needs a content type to be the subsite, but beyond that it doesn't need anything else to work. You can use it with the types provided by subsites, or you can use it with your own content types, which is how H&F is set up. H&F don't even have subsites turned on, and I'm planning to remove the module and its dependencies entirely at some point.

You could go totally off the wall and have the service landing page as your subsite type and give each service its own colour scheme if you wanted to...

markconroy commented 1 month ago

This sounds like it might make a nice generic module for Drupal.org rather than just for LGD.

Well done.