Better path alias for Subsite child pages

[Adnan-cds]

What does this change?

Currently, path aliases of child pages of Subsites are missing the Subsite homepage's path alias. This breaks breadcrumbs. This is particularly evident when Service pages are used child pages. For example, if a Service page called "Child" is added to a Subsite homepage called "Parent", the child page still gets a path alias of /child. This change ensures that child pages get path aliases of the /parent/child format.

How to test

• Add a child page to a Subsite. The child page can be of any content type.
• Note the path alias of the Subsite homepage.
• The above path alias should be present as a prefix of the child page's path alias.

[finnlewis]

Not had a chance to test this and less familiar with this module. @rupertj any time to give it a review?

[finnlewis]

Still keen to make time to test this, but not had a chance.

[rupertj]

Me too!

[rupertj]

I've been manually testing this. So far I've:

• Installed LGD and enabled subsites, subsites_extras and guides.
• Edited the parent field on the subsite page type and made it optional.
• Added a subsite overview titled "Ru's subsite". It got the alias /rus-subsite
• Added a child subsite page titled "Subsite child page". It got the alias /rus-subsite/subsite-child-page
• Added a guide overview titled "A guide" to the subsite. It got the alias /rus-subsite/guide
• Added a guide page to the guide titled "Step one". It got the alias /rus-subsite/guide/step-one

This looks like it's working perfectly to me. I'd like it to have test coverage though.

Edit: It has test coverage already. I missed that somehow!

[rupertj]

And just to check for regressions, a guide created outside of the subsite called "Some other guide" got the alias "/some-other-guide" like normal.

[Adnan-cds]

Thank you.