localgovdrupal / localgov_workflows

Default editorial workflow for LocalGov Drupal content.
GNU General Public License v2.0
0 stars 1 forks source link

Allow sitebuilders to explicitly enable review date on selected content types #50

Open andybroomfield opened 1 year ago

andybroomfield commented 1 year ago

Currently to enable review date, a site builder will add the review date widget to the manage display form on the relevant content type, which can only be enabled if scheduled transitions is enabled for the selected type.

This however can make it hard to determine which content types are set up for review dates and which havn't had it added yet. It would be better to allow sitebuilders to see and change at a glance which content types review date should be added to, and auto add the display widget (allowing site builders to disable it if they wish). This would work simmilar to schduled transitions / workflows enabled entity types section http://localgov.lndo.site:8000/admin/config/workflow/scheduled-transitions

stephen-cox commented 1 year ago

I think all that needs to happen to enable the review date functionality is to enable the review date module and then ensure scheduled transitions are enabled for a content type. The review date field should be added to the display options for this content type automatically. It can of course be moved around or hidden.

It is a kind of side-effect of changing scheduled transitions config and so admin control to explicitly manage this does make sense.

Sounds like you would prefer to see a page dedicated to this rather than adding it to a content types settings page?

andybroomfield commented 1 year ago

Something like that, it's currently a bit hard to tell which ones have review date without going through everything, and taking the review date widget off a manage display form dosn't remove old reviews (which it shouldn't in case its taken off by accident). Sounds like something that needs wider discussion.