search

localgovdrupal / localgov_workflows

Default editorial workflow for LocalGov Drupal content.
GNU General Public License v2.0
0 stars 1 forks source link

Unpublished content should not be in review queue #59

Open andybroomfield opened 11 months ago

andybroomfield commented 11 months ago

Is the point of the Needs Review admin view to review content that is currently published?

We've ran into a strange scenrio where pages that where archived are appearing in the review queue. Also pages that are reset to draft getting a review data set.

Our short term fix is to add a filter to remove unlublished content.

I think this is to do with both the scheduled transition that is being set, and the review entity. I think the review entity needs to be deleted or set to non active when a page is set to any state except published as at that point the page content can be inferred to have changed and a new review will need to be scheduled when a page is republished anyway. The review scheduled transition should also be removed.

stephen-cox commented 11 months ago

Easy enough to add a filter to hide unpublished / archived content.

The view lists content with a needs review set. I'm wary about deleting review entities just because the content has been archived. I can see though that's it's undesirable to have archive content be converted to draft once a review date passes.

andybroomfield commented 11 months ago

We have set it to filter unpublished which solves the underlying issue. The issue we are having is that archived content is being put into review (by scheduled transitions) even though the page is archived. We need to delete any pending scheduled transitions when a page is archived. As for deleting the review entites, i suppose it doens't matter really, they just clog up the DB but shouldn't do anything. It's just that once something is archived any new edits should generate a new review (which I think it should).