Review entity label should use the content label

localgovdrupal / localgov_workflows

Default editorial workflow for LocalGov Drupal content.

GNU General Public License v2.0

0 stars 1 forks source link

Review entity label should use the content label #60

Closed andybroomfield closed 1 year ago

andybroomfield commented 1 year ago

When adding a bulk operations to deal with rouge reviews, the review entity labels are blank as they don't have a label. Maybe they should actully use the label of the content they reference?

andybroomfield commented 1 year ago

Adding this to localgov_workflows/modules/localgov_review_date/src/Entity/ReviewDate.php

  /**
   * {@inheritdoc}
   */
  public function label() {
    return $this->getEntity()->label();
  }

does seem to resolve this issue, so maybe that is a way forward. Can we assume that review date entities will always have entities connected with them?