Closed millnut closed 9 months ago
The work on https://github.com/localgovdrupal/localgov_project/pull/131 has highlighted some PHP 8.2 and PHPStan issues which need fixing.
------ ------------------------------------------------------------------------------------------------------------------------------------------ Line modules/contrib/localgov_workflows/modules/localgov_review_date/src/Plugin/Field/FieldType/ReviewDateItem.php ------ ------------------------------------------------------------------------------------------------------------------------------------------ 51 Access to an undefined property Drupal\localgov_review_date\Plugin\Field\FieldType\ReviewDateItem::$review. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 51 Access to an undefined property Drupal\localgov_review_date\Plugin\Field\FieldType\ReviewDateItem::$review_langcode. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 51 Access to an undefined property Drupal\localgov_review_date\Plugin\Field\FieldType\ReviewDateItem::$reviewed. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 65 Access to an undefined property Drupal\localgov_review_date\Plugin\Field\FieldType\ReviewDateItem::$reviewed. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 65 Method Drupal\localgov_review_date\Plugin\Field\FieldType\ReviewDateItem::postSave() should return bool but return statement is missing. 70 Access to an undefined property Drupal\localgov_review_date\Plugin\Field\FieldType\ReviewDateItem::$langcode. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 78 Access to an undefined property Drupal\localgov_review_date\Plugin\Field\FieldType\ReviewDateItem::$review. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 87 Access to an undefined property Drupal\localgov_review_date\Plugin\Field\FieldType\ReviewDateItem::$langcode. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 96 Access to an undefined property Drupal\localgov_review_date\Plugin\Field\FieldType\ReviewDateItem::$langcode. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 113 Access to an undefined property Drupal\localgov_review_date\Plugin\Field\FieldType\ReviewDateItem::$review. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property ------ ------------------------------------------------------------------------------------------------------------------------------------------ ------ -------------------------------------------------------------------------------------------------------- Line modules/contrib/localgov_workflows/tests/src/Functional/RequireLogTest.php ------ -------------------------------------------------------------------------------------------------------- 44 Access to an undefined property Drupal\Tests\localgov_workflows\Functional\RequireLogTest::$adminUser. 💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property ------ --------------------------------------------------------------------------------------------------------
The work on https://github.com/localgovdrupal/localgov_project/pull/131 has highlighted some PHP 8.2 and PHPStan issues which need fixing.