localgovdrupal / localgov_workflows

Default editorial workflow for LocalGov Drupal content.
GNU General Public License v2.0
0 stars 1 forks source link

Strict types support #83

Open millnut opened 3 months ago

millnut commented 3 months ago

With Drupal core moving towards strict types, more info I've added a test pipeline in preparation https://github.com/localgovdrupal/localgov_project/pull/153 which has highlighted some failures which we should fix.

 ------ --------------------------------------------------------------- 
  Line   modules/contrib/localgov_workflows/localgov_workflows.install  
 ------ --------------------------------------------------------------- 
  62     Call to function in_array() requires parameter #3 to be set.   
  126    Call to function in_array() requires parameter #3 to be set.   
 ------ --------------------------------------------------------------- 

 ------ -------------------------------------------------------------- 
  Line   modules/contrib/localgov_workflows/localgov_workflows.module  
 ------ -------------------------------------------------------------- 
  22     Call to function in_array() requires parameter #3 to be set.  
  122    Call to function in_array() requires parameter #3 to be set.  
  126    Call to function in_array() requires parameter #3 to be set.  
 ------ -------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------------------------- 
  Line   modules/contrib/localgov_workflows/modules/localgov_review_date/localgov_review_date.module  
 ------ --------------------------------------------------------------------------------------------- 
  21     Call to function in_array() requires parameter #3 to be set.                                 
 ------ --------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------- 
  Line   modules/contrib/localgov_workflows/modules/localgov_review_date/tests/src/Kernel/ReviewDateEntityTest.php  
 ------ ----------------------------------------------------------------------------------------------------------- 
  56     Call to method Drupal\KernelTests\KernelTestBase::setUp() with                                             
         incorrect case: setup                                                                                      
 ------ ----------------------------------------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------------- 
  Line   modules/contrib/localgov_workflows/tests/src/Functional/WorkflowsAccessTest.php  
 ------ --------------------------------------------------------------------------------- 
  141    Parameter #1 $node of method                                                     
         Drupal\Tests\localgov_workflows\Functional\WorkflowsAccessTest::updateState()    
         expects Drupal\node\Entity\Node, Drupal\node\NodeInterface given.                
  154    Parameter #1 $node of method                                                     
         Drupal\Tests\localgov_workflows\Functional\WorkflowsAccessTest::updateState()    
         expects Drupal\node\Entity\Node, Drupal\node\NodeInterface given.                
 ------ --------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------- 
  Line   modules/contrib/localgov_workflows/tests/src/Kernel/WorkflowsEnableTest.php  
 ------ ----------------------------------------------------------------------------- 
  41     Call to method Drupal\KernelTests\KernelTestBase::setUp() with               
         incorrect case: setup                                                        
 ------ ----------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------ 
  Line   modules/contrib/localgov_workflows/tests/src/Kernel/WorkflowsInstallTest.php  
 ------ ------------------------------------------------------------------------------ 
  46     Call to method Drupal\KernelTests\KernelTestBase::setUp() with                
         incorrect case: setup                                                         
 ------ ------------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------------------------- 
  Line   modules/contrib/localgov_workflows/tests/src/Kernel/WorkflowsScheduledTransitionsTest.php  
 ------ ------------------------------------------------------------------------------------------- 
  45     Call to method Drupal\KernelTests\KernelTestBase::setUp() with                             
         incorrect case: setup                                                                      
 ------ -------------------------------------------------------------------------------------------