localpcguy / cbloader

Automatically exported from code.google.com/p/cbloader
1 stars 0 forks source link

Merge order is strange #41

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Download or create lots of .part files (I have 18)
2. Name them with prepended numbers to try to control the order they merge in 
(important for AppendNodes etc.)
3. Run CBloader

What is the expected output? What do you see instead?
 Past behavior was to merge the files in name order. Now, some files show up at the end, for no reason I can discern. Here's a copy of my latest log file, with copyrighted information scrubbed:

1/13/2011 6:08:27 AM - INFO: Merging 03 XXXXXXXX.part...
1/13/2011 6:09:00 AM - INFO: Merging 04 XXXXXXXX.part...
1/13/2011 6:09:03 AM - INFO: Merging 04 YYYYYYYY.part...
1/13/2011 6:09:22 AM - INFO: Merging 05 XXXXXXXX.part...
1/13/2011 6:09:37 AM - INFO: Merging 07 XXXXXXXX.part...
1/13/2011 6:09:40 AM - INFO: Merging 10 XXXXXXXX.part...
1/13/2011 6:09:46 AM - INFO: Merging 10 YYYYYYYY.part...
1/13/2011 6:09:46 AM - INFO: Merging 10 ZZZZZZZZ.part...
1/13/2011 6:10:02 AM - INFO: Merging 14 XXXXXXXX.part...
1/13/2011 6:10:06 AM - INFO: Merging 16 XXXXXXXX.part...
1/13/2011 6:10:28 AM - INFO: Merging 30 XXXXXXXX.part...
1/13/2011 6:10:29 AM - INFO: Merging 97 XXXXXXXX.part...
1/13/2011 6:10:30 AM - INFO: Merging 98 XXXXXXXX.part...
1/13/2011 6:10:30 AM - INFO: Merging YYYYYYYY.part...
1/13/2011 6:10:31 AM - INFO: Merging combined.dnd40.part...
1/13/2011 6:10:32 AM - INFO: Merging 08 XXXXXXXX.part...
1/13/2011 6:10:33 AM - INFO: Merging 09 XXXXXXXX.part...
1/13/2011 6:10:40 AM - INFO: Merging Hallowdwell.part...
1/13/2011 6:10:40 AM - INFO: Merging XXXXXXXX.part...

I would expect the "08" and "09" files to merge between "07" and "10", for the 
files without prepended numbers to go "Hallowdwell" (my home campaign, heh), 
"XXXXXXXX", "YYYYYYYYY", and combined.dnd40.part to come last. Instead, we get 
the above. This causes problems--a node of "XXXXXXXX" is Appended by 
"YYYYYYYY", meaning that update doesn't function.

What version of the product are you using? On what operating system?
 1.1.6, Windows 7

Original issue reported on code.google.com by sabre...@gmail.com on 13 Jan 2011 at 12:31

GoogleCodeExporter commented 9 years ago
I was able to get the expected merge order by deleting most of the temporary 
files from the CBloader app data folder. Maybe this is a consequence of the new 
merge order logic introduced in 1.1.6--if so, it's causing some unintended 
behavior with AppendNodes.

Original comment by sabre...@gmail.com on 14 Jan 2011 at 1:23

GoogleCodeExporter commented 9 years ago
This is a result of the 1.1.6 update. I intend to make changes to the 
implementation to fix this... at some point.

Original comment by jeff.h...@gmail.com on 31 Jan 2011 at 2:58

GoogleCodeExporter commented 9 years ago
Disabled that code in 1.3.0.  Using the new method, it's actually slower to 
split it into two groups.

Original comment by YeOldeSt...@gmail.com on 20 Aug 2011 at 6:16