localpcguy / cbloader

Automatically exported from code.google.com/p/cbloader
1 stars 0 forks source link

YeOldeSteve updates #8

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Wow, that was just over an hour of hand-merging (and a bit of added 
documentation).

Attached is a diff with most of my modifications to the source.  I dropped my 
version of multi-part merging, and have also dropped a few pieces that that 
were made obselete by ability to have multiple folders. Other than that, all my 
modifications are in there.

Original issue reported on code.google.com by YeOldeSt...@gmail.com on 25 Nov 2010 at 12:34

Attachments:

GoogleCodeExporter commented 9 years ago
Hey Steve, this looks like some great stuff, specifically the merging and 
permission improvements.
I'll want to take a few to review it and see what makes sense. I'm hesitant to 
make this tool too large. Specifically some of the character-level stuff might 
go beyond scope.

Could you provide a quick 1-line description of each new feature/bugfix in this 
diff. 

Original comment by jeff.h...@gmail.com on 26 Nov 2010 at 5:46

GoogleCodeExporter commented 9 years ago
Note that this came from my phone, as I have no pc acess until the 5th.

Attached is an updated diff, with characterManager removed, and many more 
comments.

I am considering a second helper utility to put that stuff into, and will 
persue that at a later point.  

A quick feature list:
 Improved node editing
  AppendNode
  RemoveNode
 UAC compatibility mode
  This will fix issue 14, by the way.
 File association
 Fast load mode
  Launches first, merges second.  Might later change that to threading, but that's irelevant for now.
 Passes unknown args to CB.

Note that this diff was hand-edited in Microsoft Pocket Word - and may need 
some fixing before it works.

Original comment by YeOldeSt...@gmail.com on 29 Nov 2010 at 8:03

Attachments:

GoogleCodeExporter commented 9 years ago
Gah, it apparently didn't work the first time, so I'll try again.

new diff, without CharacterManager stuff, and more comments.

new features:
 UAC compatibiliy - fixes issue 14
 File association
 New merge options
  AppendNode
  RemoveNode
    I'll explain these in detail when I get PC acess on the 5th (or get a spare hour while I have phone reception)
 Fast mode - launch first, merge second.

I may have missed something.

(sent from Mobile phone, and diff was hand-edited from the first one posted.  
It may need fixing)

Original comment by YeOldeSt...@gmail.com on 29 Nov 2010 at 8:11

Attachments:

GoogleCodeExporter commented 9 years ago
Appreciated. I'm going to get UAC Compatibility patched in today.

I'd also considered a seperate utility for more content-creator related tasks.

I have added you as a committer on this project. 

Original comment by jeff.h...@gmail.com on 29 Nov 2010 at 3:11

GoogleCodeExporter commented 9 years ago
Do you want me to commit my changes, or are you going to?

Original comment by YeOldeSt...@gmail.com on 6 Dec 2010 at 11:35

GoogleCodeExporter commented 9 years ago
I have deployed your File Association code in the latest release. 

I implemented my own UAC fix.

I haven't really looked at the new merge modes.

I'm not sure what 'fast mode' is ideal for? If you launch before you merge, 
you're not going to get the latest data. That's likely to confuse users.

Original comment by jeff.h...@gmail.com on 9 Dec 2010 at 3:23

GoogleCodeExporter commented 9 years ago
I'm often tweaking part files, and if I want to quickly launch Character 
Builder without an additional 10-20 seconds of merging, so I can quickly look 
at a character, I use Fast mode.  It isn't meant to be the standard usage.

Original comment by YeOldeSt...@gmail.com on 10 Dec 2010 at 12:16

GoogleCodeExporter commented 9 years ago
sure. Makse sense. If you'd like to check in fast mode, feel free.

Original comment by jeff.h...@gmail.com on 10 Dec 2010 at 2:24

GoogleCodeExporter commented 9 years ago

Original comment by YeOldeSt...@gmail.com on 10 Dec 2010 at 11:51