search

localstack / aws-sam-cli-local

Simple wrapper around AWS SAM CLI for use with LocalStack
Apache License 2.0
48 stars 8 forks source link

Initial implementation of a CI pipeline #14

Closed simonrw closed 7 months ago

simonrw commented 7 months ago

Motivation

We should have CI for our tools to make sure they stay working with the current version of LocalStack

Changes

simonrw commented 7 months ago

I disagree with some of your suggestions, but am slightly torn with the sample application cleanup. On the one hand it's better to leave it as an example of the "quickstart" application, but as it's only used for testing it is a lot of text that provides no value. I have cleaned it up a bit to remove unneeded files e.g. README.md etc.

I do think we should leave the packaging step in (i.e. adding requests as a dependency) since this ensures asset upload works.

joe4dev commented 7 months ago

I disagree with some of your suggestions, but am slightly torn with the sample application cleanup. On the one hand it's better to leave it as an example of the "quickstart" application, but as it's only used for testing it is a lot of text that provides no value. I have cleaned it up a bit to remove unneeded files e.g. README.md etc.

I do think we should leave the packaging step in (i.e. adding requests as a dependency) since this ensures asset upload works.

It's great that we can disagree 🥳 :)

Functionally, I think it's good that we cover at least the generated functionality. I think auto-generated documentation causes more confusion in the wrong context without adaptation.

Agree on the assets upload 👍