search

localstack / aws-sam-cli-local

Simple wrapper around AWS SAM CLI for use with LocalStack
Apache License 2.0
48 stars 8 forks source link

Accept AWS conform ECR URIs #20

Closed lakkeger closed 3 weeks ago

lakkeger commented 1 month ago

Motivation

LocalStack 3.4 introduced the new ECR_ENDPOINT_STRATEGY which defaults to domain. By that, the previously used ECR repository URIs (localhost.localstack.cloud:4510/sample) started to fail as LocalStack was expecting the AWS pattern (000000000000.dkr.ecr.us-east-1.localhost.localstack.cloud:4566/sample), however the usage of the new pattern resulted in the following error message:

Error: Invalid value for '--image-repository': Invalid Image Repository ECR URI: image_repository = 000000000000.dkr.ecr.us-east-1.localhost.localstack.cloud:4566/sample

Changes

whummer commented 3 weeks ago

FYI @lakkeger @HarshCasper - bumped the version in this PR. Going to merge and publish a new version to pypi now. 👍