search

localstack / localstack-java-utils

☕ Java utilities and JUnit integration for LocalStack
Apache License 2.0
75 stars 43 forks source link

enable "Cloudwatch Logs" service=logs #11

Closed dhagan-va closed 4 years ago

dhagan-va commented 4 years ago

What a cool -project and it is working well for me. Nice work!

I do not see service logs in public class ServiceName {} "Cloudwatch Logs" is supported in localstack on the default port 4586. Is this something that could be easily enabled?

whummer commented 4 years ago

Hi @dhagan-va , thanks for suggesting this improvement. Do you think you could contribute a small pull request to add the missing functionality? That would be much appreciated - thanks!

dhagan-va commented 4 years ago

Hi @whummer could you give me a handrail/sketch of what I would need to change and I might give it a shot? Thank you!

ceejaey commented 4 years ago

@whummer, I've done a possible implementation of this to submit for review, but I'm not sure how do you tend to approach version numbering of the POM file, would you like this incremented as a minor version?

whummer commented 4 years ago

Hi @ceejaey , that sounds great - looking forward to reviewing the change. Yes, if you could please increment the minor version number for this change (and add a short note to the change log in the README), then we can release a new version right away. Thanks!

whummer commented 4 years ago

Fixed in #18 - thanks!