search

localstack / localstack-java-utils

☕ Java utilities and JUnit integration for LocalStack
Apache License 2.0
75 stars 43 forks source link

check the content of the msg in each encoding type #34

Closed pinzon closed 3 years ago

pinzon commented 3 years ago

With this PR the tests for each Kinesis version asserts that the content is equal in CBOR and JSON. It should pass after this PR for localstack has been merged

whummer commented 3 years ago

Looks great, thanks @pinzon 👍 (still waiting for the build to succeed..)

pinzon commented 3 years ago

Hi @whummer The failing test is the one that expects the PR for cbor encoding in localstack 



[ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 36.834 s <<< FAILURE! - in cloud.localstack.KinesisConsumerTest

[ERROR] testGetRecordCBOR(cloud.localstack.KinesisConsumerTest)  Time elapsed: 2.27 s  <<< FAILURE!

org.junit.ComparisonFailure: 

expected:<[Hello world!]> but was:<[SGVsbG8gd29ybGQh

]>

    at cloud.localstack.KinesisConsumerTest.testGetRecordCBOR(KinesisConsumerTest.java:62)```