search

localstack / localstack-terraform-test

Utilities to run Terraform tests against LocalStack
25 stars 6 forks source link

Patch - Reduce Route53 sync times #10

Closed bblommers closed 2 years ago

bblommers commented 2 years ago

The Route53 tests would take a lot of time just waiting for changes to be synced. As Moto applies the changes immediately, there is no point in waiting 20+ seconds a few times per test.

This patch reduces delays and timeouts, reducing the test time for individual Route53 tests.

This PR also adds the command to automatically update Go dependencies, removing any issues surrounding wrong Terraform state versions. I'm not a Go-developer by any means, so I'm not sure whether this is the best way of doing it - open to suggestions!

whummer commented 2 years ago

Hi @bblommers , sorry for the long delay on this one - thanks for this enhancement! 👍

We'll also still need to apply these changes to the build branch, as that is currently the one referenced in the builds.

Btw, we're in the process of upgrading the test suite to the latest upstream codebase. The code has been restructured in the meantime (see https://github.com/localstack/localstack-terraform-test/issues/9), so it may also have some implications on the way we're running the build scripts, etc. We can try to leave build branch stable/as-is for now, to avoid issues with the existing pipelines. 👍

bblommers commented 2 years ago

Thanks @whummer!