localstack / terraform-local

Terraform CLI wrapper to deploy your Terraform applications directly to LocalStack
Apache License 2.0
203 stars 24 forks source link

Add support to multi-account environments #30

Closed lakkeger closed 1 year ago

lakkeger commented 1 year ago

Motivation

tflocal is only usable currently with a single account as all resources are deployed into the default one. This behavior is not ideal to run tests or develop code for many production cases when terraform code references to resources outside of this account ie to manage a domain registration or validate certificates on a central DNS managing account.

Related issue: #29

Changes

TODO

cshimmin commented 1 year ago

As an interested observer from the US, I recommend either supporting the alternative spelling CUSTOMIZE_ACCESS_KEY, or avoid the ambiguity altogether with a different name. Perhaps ACCESS_KEY_PASSTHROUGH?

alexrashed commented 1 year ago

Hi @cshimmin!

As an interested observer from the US, I recommend either supporting the alternative spelling CUSTOMIZE_ACCESS_KEY, or avoid the ambiguity altogether with a different name. Perhaps ACCESS_KEY_PASSTHROUGH?

Thanks for the comment! Actually, that was one of @whummer's PR review comments and @lakkeger already changed it in the code (but not yet in the PR description). 😛