search

localwiki / localwiki-backend-server

Primary LocalWiki backend server environment
GNU General Public License v2.0
48 stars 16 forks source link

Explore move to Leaflet #33

Open philipn opened 9 years ago

philipn commented 9 years ago

From @philipn on May 15, 2013 12:45

It looks like the leaflet draw plugin (https://github.com/Leaflet/Leaflet.draw) has gotten way better, which was the main blocker on any possible move to leaflet (http://leafletjs.com/). Leaflet would provide much better mobile support, but switching might be a bit hairy as much of our select-feature-show-what's-inside code is pretty tied to OpenLayers.

Edit: mobile editing in leaflet.draw isn't quite working yet (https://github.com/Leaflet/Leaflet.draw/issues/2), so we'll need to stick with OL for the time being or improve leaftlet.draw.

Copied from original issue: localwiki/localwiki#509

philipn commented 9 years ago
philipn commented 9 years ago

From @mapmeld on July 26, 2013 1:45

I looked into this several months ago but OpenLayers / OLMap is integrated pretty deeply into the code. I've got a better dev environment now to test and see how Leaflet might take its place. I'll let you know in the next week if I get anywhere.

philipn commented 9 years ago

The only really custom integration happens with the /map/ page, where we do things like shade polygons based on zoom and display a sidebar with dynamic map results. I think we pull in the settings and use it in the widget constructor in some spots, but otherwise should be able to make a new widget in maps/widgets.py and use that -- at least for the per-page maps

philipn commented 9 years ago

From @mapmeld on July 26, 2013 21:13

I compiled with some Leaflet code today, but /map and other map pages gave me a 500 error. I'm not familiar with debugging Django - how do I get it to show a stack trace when things go wrong?

philipn commented 9 years ago

Make sure you have DEBUG=True and TEMPLATE_DEBUG=True in your env/share/localwiki/conf/localsettings.py. Let me know if you see the error now

On Jul 26, 2013, at 2:13 PM, Nick Doiron notifications@github.com wrote:

I compiled with some Leaflet code today, but /map and other map pages gave me a 500 error. I'm not familiar with debugging Django - how do I get it to show a stack trace when things go wrong?

— Reply to this email directly or view it on GitHub.