search

localwiki / localwiki-backend-server

Primary LocalWiki backend server environment
GNU General Public License v2.0
48 stars 16 forks source link

Should we serve external images directly? #40

Open philipn opened 9 years ago

philipn commented 9 years ago

From @philipn on March 28, 2013 1:17

See discussion at the bottom of the page here: http://oaklandwiki.org/Users/Gene/_history/82

We may want to download images provided as URLs in the image dialog rather than just embedding them. What do most blogging, etc platforms do?

Copied from original issue: localwiki/localwiki#464

philipn commented 9 years ago

From @groovecoder on March 28, 2013 22:52

On MDN we do both - we allow users to add <img> elements AND we allow users to upload images (which we then show via <img> elements.

This issue is about automatically fetching img sources and turning them into attachments?

philipn commented 9 years ago

That's what we do now, but using external images should probably be discouraged. We want to serve retina scaled thumbnails, etc so we have to serve images ourselves for that.

On Mar 28, 2013, at 3:52 PM, luke crouch notifications@github.com wrote:

On MDN we do both - we allow users to add elements AND we allow users to upload images (which we then show via elements.

This issue is about automatically fetching img sources and turning them into attachments?

— Reply to this email directly or view it on GitHub.

philipn commented 9 years ago

From @rtucker on March 28, 2013 23:43

I personally lean towards serving the images ourselves. It prevents the external server from being burdened by our traffic, and keeps us in control of our performance and availability. It does mean that the image darn well better have a compatible license, but I wouldn't really want to link to an external image that doesn't. The content of the wiki should be self-contained and freely licensed.

There are exceptions to this, of course, but the default choice should be fetch and serve it ourselves. -rt

On Thu, Mar 28, 2013 at 7:06 PM, Philip Neustrom notifications@github.comwrote:

That's what we do now, but using external images should probably be discouraged. We want to serve retina scaled thumbnails, etc so we have to serve images ourselves for that.

On Mar 28, 2013, at 3:52 PM, luke crouch notifications@github.com wrote:

On MDN we do both - we allow users to add elements AND we allow users to upload images (which we then show via elements.

This issue is about automatically fetching img sources and turning them into attachments?

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/localwiki/localwiki/issues/464#issuecomment-15620760 .

Ryan Tucker rtucker@gmail.com

philipn commented 9 years ago

From @mivanov on March 28, 2013 23:50

We should consider it if there's an app that already does this that localwiki can use/extend. It seems like it would be a bit of a nightmare to implement right (security, rate limiting, errors/retries, MIME types, ...??) for relatively little benefit. I could see someone wanting to take on a project like this though!