localwiki / localwiki-backend-server

Primary LocalWiki backend server environment
GNU General Public License v2.0
48 stars 16 forks source link

Weird username with __ in it #65

Closed philipn closed 9 years ago

philipn commented 9 years ago

From @philipn on October 8, 2012 3:33

http://arborwiki.org/Users/___DavidBenowitz____ maps to http://arborwiki.org/Users/DavidBenowitz

Copied from original issue: localwiki/localwiki#354

philipn commented 9 years ago

From @vielmetti on October 8, 2012 3:41

It looks like the user name was _DavidBenowitz_ with three leading and trailing underscores; the automatic mapping turn this into Page "Users/ DavidBenowitz" does not exist (yet!)
with a single space before the DavidBenowitz.

Similarly, when I create the page

http://arborwiki.org/Users/EdwardVielmetti/___test___

I get redirected back to

Page "Users/EdwardVielmetti/ test" does not exist (yet!)

with a leading space before "test". And, when that page it saved, it saves without the leading space before "test", as

http://arborwiki.org/Users/EdwardVielmetti/test

philipn commented 9 years ago

From @mivanov on October 8, 2012 3:52

@philipn did we change the handling of slashes? I think the behavior I had originally was to strip spaces (underscores in the url) from every component between slashes. This is important for reserving future urls namespaced with underscore for special things. The other issue of course is do we then want to enforce some rules on the username, and I think we probably do

On Oct 7, 2012, at 8:41 PM, Edward Vielmetti notifications@github.com wrote:

It looks like the user name was DavidBenowitz with three leading and trailing underscores; the automatic mapping turn this into Page "Users/ DavidBenowitz" does not exist (yet!)

with a single space before the DavidBenowitz.

Similarly, when I create the page

http://arborwiki.org/Users/EdwardVielmetti/___test___

I get redirected back to

Page "Users/EdwardVielmetti/ test" does not exist (yet!)

with a leading space before "test".

— Reply to this email directly or view it on GitHubhttps://github.com/localwiki/localwiki/issues/354#issuecomment-9215793.

philipn commented 9 years ago

I thought that was the behavior, too. I'm not sure why it should have changed. Should find out

On Oct 7, 2012, at 8:52 PM, mivanov notifications@github.com wrote:

@philipn did we change the handling of slashes? I think the behavior I had originally was to strip spaces (underscores in the url) from every component between slashes. This is important for reserving future urls namespaced with underscore for special things. The other issue of course is do we then want to enforce some rules on the username, and I think we probably do

On Oct 7, 2012, at 8:41 PM, Edward Vielmetti notifications@github.com wrote:

It looks like the user name was DavidBenowitz with three leading and trailing underscores; the automatic mapping turn this into Page "Users/ DavidBenowitz" does not exist (yet!)

with a single space before the DavidBenowitz.

Similarly, when I create the page

http://arborwiki.org/Users/EdwardVielmetti/___test___

I get redirected back to

Page "Users/EdwardVielmetti/ test" does not exist (yet!)

with a leading space before "test".

— Reply to this email directly or view it on GitHubhttps://github.com/localwiki/localwiki/issues/354#issuecomment-9215793. — Reply to this email directly or view it on GitHub.

philipn commented 9 years ago

I think this may be the non-ASCII username change.

On Oct 7, 2012, at 8:52 PM, mivanov notifications@github.com wrote:

@philipn did we change the handling of slashes? I think the behavior I had originally was to strip spaces (underscores in the url) from every component between slashes. This is important for reserving future urls namespaced with underscore for special things. The other issue of course is do we then want to enforce some rules on the username, and I think we probably do

On Oct 7, 2012, at 8:41 PM, Edward Vielmetti notifications@github.com wrote:

It looks like the user name was DavidBenowitz with three leading and trailing underscores; the automatic mapping turn this into Page "Users/ DavidBenowitz" does not exist (yet!)

with a single space before the DavidBenowitz.

Similarly, when I create the page

http://arborwiki.org/Users/EdwardVielmetti/___test___

I get redirected back to

Page "Users/EdwardVielmetti/ test" does not exist (yet!)

with a leading space before "test".

— Reply to this email directly or view it on GitHubhttps://github.com/localwiki/localwiki/issues/354#issuecomment-9215793. — Reply to this email directly or view it on GitHub.

philipn commented 9 years ago

Haven't seen this. Closing.