localytics / odbc_adapter

An ActiveRecord ODBC adapter
MIT License
46 stars 107 forks source link

QueryTimeoutError only takes one argument. #20

Open nickelser opened 6 years ago

nickelser commented 6 years ago

Resolves the wrong number of arguments (given 2, expected 0..1) exception with timeouts.

j3pic commented 6 years ago

The TravisCI test failed, but it's a problem with the test environment and not this PR:

The following packages have unmet dependencies:
 mysql-client : Depends: mysql-client-5.5 but it is not going to be installed
ziggythehamster commented 6 years ago

@nickelser You might want to fix ActiveRecord::RecordNotUnique.new(message, exception) in this PR; it only takes one argument as well.