localytics / odbc_adapter

An ActiveRecord ODBC adapter
MIT License
46 stars 107 forks source link

[MOJ-451] Migrations fail when using :boolean #48

Closed bfredenburg closed 1 year ago

bfredenburg commented 1 year ago

Source

https://springbuk-glass.atlassian.net/browse/MOJ-451

Problem

Rails migrations that use :boolean as a data type fail. The odbc_adapter code uses 'bool' in the generated SQL for the symbol :boolean. "bool" is a Postgres alias for "boolean". Snowflake does not support that alias.

Solution

"boolean" must be used instead of "bool" in the generated SQL.

Testing/QA Notes

Create and test a migration.

Post Merge Notes

Will need PRs to springbuk, edison, and probably DM to update the adapter.