get_point_values result incorrect for SPACETIME layer

jdries commented 6 years ago

I use the get_point_values method on a TiledRasterLayer of type SPACETIME. The layer has tiles at multiple time instants, so I'm in this case:

If ``points`` is a ``list`` and the ``layer_type`` is ``SPACETIME``: [(shapely.geometry.Point, datetime.datetime, [float])]

In my result, I never get tuples for only one date. I think the error is in: geopyspark.geotrellis.TemporalTiledRasterLayer._getPointValues as there a toMap method is used to return a Map[Long, (Long, Array[Double])] .

I also had a look at the unit test, and it only seems to test cases where there is only one time instant in the source data.

jbouffard commented 6 years ago

@jdries Thank you for bringing this to our attention! You're correct, the toMap is the source of the error and I'm in the process of fixing it now.

jbouffard commented 6 years ago

@jdries There's now a PR up that fixes this issue: #620 It will most likely be merged sometime early next week.

jdries commented 6 years ago

Thanks for the fast response, great help!

(I'm using GeoPySpark as a backend in a new project:

http://openeo.org/ !)

Jeroen Dries TAP - Centre for Remote Sensing and Earth Observation Processes VITO NV | Boeretang 200 | 2400 Mol tel. +32 14 33 55 11 | jeroen.dries@vito.behttps://outlook.vito.be/OWA/redir.aspx?C=bkbvq29Z1EO1hvVK0QJMbACOitzQ7c8Ip7CWFVkhZV75OTezDjCIkdDzkCq1rif2MTOFHY6bxtg.&URL=mailto%3avoornaam.naam%40vito.be

Van: Jacob Bouffard notifications@github.com Verzonden: vrijdag 19 januari 2018 17:27 Aan: locationtech-labs/geopyspark CC: Dries Jeroen; Mention Onderwerp: Re: [locationtech-labs/geopyspark] get_point_values result incorrect for SPACETIME layer (#619)

@jdrieshttps://github.com/jdries There's now a PR up that fixes this issue: #620https://github.com/locationtech-labs/geopyspark/pull/620 It will most likely be merged sometime early next week.

- You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/locationtech-labs/geopyspark/issues/619#issuecomment-359017211, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFqXyNlZmkxJ5JxJZn6IjO_N681Ed_Piks5tMMKMgaJpZM4RjYhH.

Indien u VITO Mol bezoekt, hou aub er dan rekening mee dat de hoofdingang voortaan enkel bereikbaar is vanuit de richting Dessel-Retie, niet vanuit richting Mol, zie vito.be/route.http://www.vito.be/route If you plan to visit VITO at Mol, then please note that the main entrance can only be reached coming from Dessel-Retie and no longer coming from Mol, see vito.be/en/contact/locations.http://www.vito.be/en/contact/locations VITO Disclaimer: http://www.vito.be/e-maildisclaimer

rossbernet commented 6 years ago

@jdries This looks like a really exciting project. Great you are using GeoPySpark. We are definitely happy to help.

There will be three people that work on GeoTrellis / GeoPySpark in Bonn in March for the OS Code Sprint. Will you or anyone from your team be attending? It could be a great opportunity to discuss in person.

jbouffard commented 6 years ago

@jdries You're welcome! That's a cool project! Please let us know if you have any questions/need help with GPS on our gitter channel.

locationtech-labs / geopyspark

get_point_values result incorrect for SPACETIME layer #619