locationtech-labs / geopyspark

GeoTrellis for PySpark
Other
179 stars 59 forks source link

Ensure multiple concurrent notebooks can create TMS servers #626

Closed jpolchlo closed 6 years ago

jpolchlo commented 6 years ago

When working with multiple notebooks that wish to use the TMS server, we were jumping the gun and starting the Py4J callback server using the wrong method and too soon. This should fix the problem and avoid port collisions in the future.

I've tested that this change preserves functionality with the following script: https://gist.github.com/jpolchlo/c9c432501fa47a276a6d719095753ee4#file-srtm-orc-tobler-display-tms-callback-test-ipynb

Signed-off-by: jpolchlo jpolchlopek@azavea.com

jbouffard commented 6 years ago

This looks good to me :+1: