search

locationtech-labs / geopyspark

GeoTrellis for PySpark
Other
179 stars 59 forks source link

The hillshade Function Will Now Use the ZFactorCalculator #645

Closed jbouffard closed 6 years ago

jbouffard commented 6 years ago

This PR changes the API of the hillshade function so that it uses a ZFactorCalculator to compute the z factor for each Tile rather than having a single z factor for all Tiles. By using a ZFactorCalculator, the resulting hillshade will be more accurate.

Note: This will break any preexisting code that uses the old hillshade function.

jbouffard commented 6 years ago

@echeipesh Would you like to look over this again? Or should I just merge it? I addressed most of your comments.

echeipesh commented 6 years ago

I think its good