locationtech / geotrellis

GeoTrellis is a geographic data processing engine for high performance applications.
http://geotrellis.io
Other
1.33k stars 362 forks source link

fix: The geotrellis-store module is missing dependency. #3461

Closed imperio-wxm closed 2 years ago

imperio-wxm commented 2 years ago

The module geotrellis-store is missing guava and uzaygezenCore dependency. Without these two dependencies, the compilation will report the error as shown in the figure. After the repair, the compile and test case are successful via sbt. Unit tests can also run normally after the complete project is imported into IntelliJ Idea.

image

pomadchin commented 2 years ago

Hey @imperio-wxm, I'm confused; how that could be? Check out the published geotrellis-store deps: https://mvnrepository.com/artifact/org.locationtech.geotrellis/geotrellis-store_2.12/3.6.2

imperio-wxm commented 2 years ago

Hey @imperio-wxm, I'm confused; how that could be? Check out the published geotrellis-store deps: https://mvnrepository.com/artifact/org.locationtech.geotrellis/geotrellis-store_2.12/3.6.2

Sorry, I made a mistake. uzaygezenCore is already there, what is missing is guava, you can check the deps pom file: https://repo1.maven.org/maven2/org/locationtech/geotrellis/geotrellis-store_2.12/3.6.2/geotrellis-store_2.12-3.6.2.pom

pomadchin commented 2 years ago

@imperio-wxm but why guava is needed? It is not used by any project except cassandra / hbase. What guava error you have?

imperio-wxm commented 2 years ago

@imperio-wxm but why guava is needed? It is not used by any project except cassandra / hbase. What guava error you have?

I found in the class of this module geotrellis-store, which uses com.google.common.base.Functions

image

pomadchin commented 2 years ago

@imperio-wxm but uzaygezen has guava as a transitive dep: https://mvnrepository.com/artifact/com.google.uzaygezen/uzaygezen-core/0.2

imperio-wxm commented 2 years ago

@imperio-wxm but uzaygezen has guava as a transitive dep: https://mvnrepository.com/artifact/com.google.uzaygezen/uzaygezen-core/0.2

Hi, I'm also confused, guava-14.0-rc1 can't be imported in. There may be coverage or other problems between sbt dependencies. image

pomadchin commented 2 years ago

Yea, I am not sure what is the difference and why on your machine the compilation / import does not work though, since the CI is happy regardless of guava versions included 🤷

pomadchin commented 2 years ago

I think I'm going to close it for now, we can revisit it later if there will be a need; but since tests are passing in CI there is not need in merging it.

Feel free to reopen it though / open another issue! Don't forget to sign ECA in this case to make Eclipse license checker happy.