search

locationtech / jts

The JTS Topology Suite is a Java library for creating and manipulating vector geometry.
Other
1.95k stars 440 forks source link

Fix vertex-vertex intersection in OverlayArea #1040

Closed tanelk closed 6 months ago

tanelk commented 6 months ago

Fixes a known bug in OverlayArea. There were two issues present:

  1. The possibility of COLLINEAR orientation was not handled
  2. Intersections at a vertex (non-proper) were double-counted
dr-jts commented 6 months ago

Thanks for looking into this!

tanelk commented 6 months ago

I marked it as draft - there are quite many edge cases I did not see at first. It fixes some, but breaks others.

dr-jts commented 6 months ago

Ah, too bad. Hopefully there's a way to resolve all the problems.

dr-jts commented 6 months ago

So this ultimately didn't solve enough of the problems?

tanelk commented 6 months ago

Had to go with a more involved approach in #1043