search

locationtech / jts

The JTS Topology Suite is a Java library for creating and manipulating vector geometry.
Other
1.94k stars 441 forks source link

Fixed TriangleEdgesListVisitor #943

Closed SonarSonic closed 1 year ago

SonarSonic commented 1 year ago

Currently the TriangleEdgesListVisitor, simply adds the provided QuadEdge[] triEdges array too the list, however this array is always the same instance, as fetchTriangleToVisit just updates the same array each time, see below.

https://github.com/locationtech/jts/blob/1c0902d47f96f383be3723cfc2c5c24f60cbe0dc/modules/core/src/main/java/org/locationtech/jts/triangulate/quadedge/QuadEdgeSubdivision.java#L693

So currently a call to getTriangleEdges will provide a list of identical arrays, this change fixes that by creating a new instance of the array passed too the TriangleEdgesListVisitor so the getTriangleEdges method now performs as expected.

dr-jts commented 1 year ago

@SonarSonic are you able to fill out an Eclipse ECA so this can be merged?

SonarSonic commented 1 year ago

Opened a duplicate commit with the correct email to verify the ECA #945