Closed mukoki closed 1 year ago
I tried to follow your suggestions about identification of nodes on shells sharing only one point. Finally, this new pull request fix several bugs :
On a significative dataset (117 Mb), the processing time goes from 41.5 s to 46.5 s after applying the PR.
You'll need to rebase, since I pushed a fix to GeometryTestCase
.
Sorry, with the different commits, sync and rebase, I'm not sure the PR is still usable for you. Let me know. I've also made a separate PR where I replaced the BitSet trick by a second MultiLineString to pass the unconstrained rings. Use the one you prefer or another way if you have a precise idea in mind.
This PR looks good, with one small change request as noted in a comment (pass the BItSet as an explicit parameter to TPVWSImplifier
).
Replace the previous pull request #961 : fix both issues #953 and #962 according to the discussion.
Fixes #953. Fixes #962.