search

locationtech / jts

The JTS Topology Suite is a Java library for creating and manipulating vector geometry.
Other
1.94k stars 442 forks source link

calling getX to set the minY? #983

Closed aocalderon closed 1 year ago

aocalderon commented 1 year ago

Just to confirm if it is correct... I think it should call getY() instead of getX()...

https://github.com/locationtech/jts/blob/5d3de32bd361e19a9d5660958c1ca48ce8d06970/modules/core/src/main/java/org/locationtech/jts/index/hprtree/HilbertEncoder.java#L32

dr-jts commented 1 year ago

Good find! A copy-and-paste error, of course. Will fix soon.

On Sat., Jun. 10, 2023, 7:57 a.m. Andres Calderon, @.***> wrote:

Just to confirm if it is correct... I think it should call getY() instead of getX()...

https://github.com/locationtech/jts/blob/5d3de32bd361e19a9d5660958c1ca48ce8d06970/modules/core/src/main/java/org/locationtech/jts/index/hprtree/HilbertEncoder.java#L32

— Reply to this email directly, view it on GitHub https://github.com/locationtech/jts/issues/983, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA25SXNZYFN7TIXEH6WQLQ3XKQEFDANCNFSM6AAAAAAZBPB2TI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

dr-jts commented 1 year ago

Fixed by https://github.com/locationtech/jts/commit/2d2a1a966491c3dd1381bd4fcf2923b5872ef53c