locationtech / proj4j

Java port of the Proj.4 library for coordinate reprojection
Other
184 stars 73 forks source link

Add GeostationarySatelliteProjection #22

Closed Yaqiang closed 5 years ago

Yaqiang commented 5 years ago

Add GeostationarySatelliteProjection class for geostationary satellite projection. "h" was added in Proj4Keyword, and is parsed in Proj4Parser as heightOfOrbit in Projection.

pomadchin commented 5 years ago

Hey, thanks for your contribution! That's really cool. But I'm afraid you need to sign Eclipse CLA and to sign off all of your commits. To do it just add a special flag to the commit cmd: git commit -s -m "message"

For instance to fix you last commit do git commit --amend -s.

How to sign CLA and other instructions are here: https://github.com/locationtech/proj4j/blob/master/CONTRIBUTING.md#sign-off-on-commits-and-filing-a-cla

Let me know if smth didn't work for you.

Yaqiang commented 5 years ago

I log in and sign My Eclipse Contributor Agreement in eclipse.org. What should I do next?

pomadchin commented 5 years ago

Sign off all your commits. Lets try to sign only the last one and see what would happen:

git commit --amend -s && git push origin -f master
pomadchin commented 5 years ago

Hey @Yaqiang it looks like you need to sign all the commits; that's what I see from the Details:

image

Well as a quick fix you can squash them and override the commit message with a single one signed off.

Yaqiang commented 5 years ago

Sorry, I have no idea how to solve the problem.

pomadchin commented 5 years ago

@Yaqiang

git rebase -i HEAD~6
// you 'll se a bucnh of commits
// first of them can be not yours
// you can notice that all of the commits would be assigned with a letter p (means pick on rebase)
// don't touch _your first_ commit (means don't touch 1f087a9)
// mark all other your commits (that were done after 1f087a9) with a letter s (squash)
// exit editor and it will finish rebasing

// after that do:
git commit --amend -s

// and edit your message to make some sense as after squashing it can contain all messages from all the commits

git push -f origin master

// voi la!
Yaqiang commented 5 years ago

@pomadchin Thanks a lot for your help on git usage!