Closed sebasbaumh closed 5 years ago
How do I handle this: Sebastian Baumhekel (sebastian.baumhekel@****.com) did not include the "Signed-off-by footer" which is required for all commits made by a contributor.
I already signed an Eclipse Contributor Agreement some time ago.
hey @sebasbaumh just do git commit --amend -s && git push origin -f threadsafeTransform
flag -s
here would add a proper footer, just be sure that you're signing your commit with the same email you signed ECA.
@pomadchin Thank you 👍
Make
BasicCoordinateTransform
thread-safe to increase performance in multi-threaded environments by reusing the same instance.The transform function does not need temporary variables anymore (which were the reason for having a stateful class). And
inverseProjectRadians
does only touch the target coordinate after calculating using the source coordinate, so it can get the same instance for both parameters.So finally with this change it is possible to reuse a
BasicCoordinateTransform
across multiple threads instead of constructing one for every single thread. Especially servlets and enterprise applications transforming coordinates on a web request will benefit from it.