locationtech / proj4j

Java port of the Proj.4 library for coordinate reprojection
Other
189 stars 73 forks source link

Updating EPSG database #4

Closed willcohen closed 6 years ago

willcohen commented 6 years ago

What should the process be for updating the EPSG database? proj.4 uses version 9.2 here but I'm not sure how that file should be cited in terms of ownership on this project (especially re the Eclipse CLA).

Moreover, using an updated EPSG database causes the test from #3 to fail again. Would it be acceptable to change the test reprojected value to the one generated by converting the point through PostGIS (which itself uses actual proj.4)?

dr-jts commented 6 years ago

Answer to the second question: I think it's acceptable to update the value to whatever value is returned by the new EPSG database (whether from proj4J itself, or some other source). Hopefully it is now correct! (Would be interesting to know why it has changed...)

Also, if the new value is simply less precise, perhaps the test precision should be reduced. (It's always a bit hard to figure out how values should be treated for the more obscure projections).

dr-jts commented 6 years ago

For #1 - @lossyrob any ideas

willcohen commented 6 years ago

It seems like the epsg and world files in the nad folder are the two things that could use an update, and they come directly from proj.4. If the proj.4 project is, overall, MIT licensed, would it work to just put a reference in LICENSE to proj.4 and that it's MIT? If that sounds good, I can add that and update those two files.

lossyrob commented 6 years ago

@willcohen yes, updating the database and changing any tests that had previous 'incorrect' values (according to the new DB params) makes a lot of sense. Thanks!

willcohen commented 6 years ago

Thanks, just submitted! Also -- for what's it worth, there did seem to be Eclipse IP validation hooks when I submitted PRs #2 and #3, though #7 didn't get one just now.

lossyrob commented 6 years ago

Closed by #7