search

locationtech / proj4j

Java port of the Proj.4 library for coordinate reprojection
Other
184 stars 73 forks source link

CoordinateTransformTester #42

Closed paulushub closed 5 years ago

paulushub commented 5 years ago

Anyone with the relevant clearance, please review the closed pull here

Update CoordinateTransformTester.java

pomadchin commented 5 years ago

@paulushub you're welcome to reopen your PR! The only thing you need to do is to submit an ECA and to sign off the commit https://github.com/locationtech/proj4j/blob/master/CONTRIBUTING.md#sign-off-on-commits-and-filing-a-cla

However, I think changes are minor, so in theory they don't require CLA (but it is still recommended).

paulushub commented 5 years ago

Just simple changes I made directly in the browser, please take it from there if possible.

Neutius commented 5 years ago

@paulushub I encountered the same problem this week when I tried to contribute for the first time. I forgot to add the -s flag to my commit (tbf, I didn't forget, I just didn't RTFM). So I made a new branch, re-committed my changes with the -s flag (signed-off-by), and made a new PR.

It was 10 minutes of work and a valuable lesson learned.

paulushub commented 5 years ago

@Neutius Thanks for the information. Unfortunately, I am not keeping a local repository of the proj4j or the local copy is not under git. The fork is just to track changes as I port the sources to .NET. The changes I was submitting were simple; deleting all problematic lines from that class to get the tests to run without errors. Anyone could just add that to his/her own PR.