locationtech / proj4j

Java port of the Proj.4 library for coordinate reprojection
Other
184 stars 73 forks source link

Minor hashCode/equals override improvements #51

Closed Neutius closed 4 years ago

Neutius commented 5 years ago
Neutius commented 5 years ago

These checks on legal agreements are getting pretty annoying.

On the Eclipse site, it has a green check mark next to "Eclipse Foundation Project", and a red cross next to "Eclipse Foundation Specification Project". Underneath that, it says:

Apparently, the problem is I pulled from locationtech to my own fork to get up to date, it automatically includes that merge commit in this pull request, and the merge commit lacks the necessary legal agreements.

The only solution I can think of right now is deleting my fork, forking again, then committing again, then offer a pull request with a single commit.

I'm new to the FOSS community, and still getting used to GitHub. Is there a better solution?

Edit: the feedback from GitHub and Eclipse don't line up. According to GitHub, the merge commit is fine. I really don't get it.