GeocentricConverter equality check after WGS param overrides

locationtech / proj4j

Java port of the Proj.4 library for coordinate reprojection

Other

186 stars 73 forks source link

GeocentricConverter equality check after WGS param overrides #77

Closed bosborn closed 2 years ago

bosborn commented 2 years ago

GeocentricConverter equality check after WGS param overrides
Previously failing tests
- EPSG:27700
- EPSG:31469
- EPSG:2056
- EPSG:4055

FIXES #32

bosborn commented 2 years ago

@pomadchin Ready for review. Added comments and cleaner links to proj.4 version 5.2.0. Backed out including the pole radius in geocentric equality comparisons to match proj.4 results.

bosborn commented 2 years ago

Any thoughts on the updates to this PR and/or the current state?

pomadchin commented 2 years ago

@bosborn oops just felt off my sight; will review it shortly 👍

pomadchin commented 2 years ago

Let me know when you need a release with this fix

bosborn commented 2 years ago

Excellent, thanks. Whenever you get the chance I could use a new release.