Closed bchapuis closed 1 year ago
Good catch, I went too fast when reporting my changes in the fork... I amended the commit.
Could you also sign ECA to make Eclipse ECA Validator happy?
This is also not really a code change so I think it is fine to merge it as is.
Thank you for helping with it! I definitely needed a second pair of eyes. :+1:
I signed the Eclipse Contributor Agreement, but there is still a problem with the "Eclipse Foundation Specification Project". Any idea where this check comes from?
Quick note on the −16,166 lines: many resources files were duplicated in the java and test directory.
@bchapuis the actual error is Could not validate the users ECA sign-off status. Please ensure that the e-mail address of all contributing accounts match a valid Eclipse Foundation account with a valid ECA.
but from the other hand I can find you with a signed ECA there; hmmm
Sorry, I have not been able to sort this out. I don't want to slow you down so feel free to ignore this PR. For future contributions, is there an administrative contact at the eclipse foundation that may help sorting this kind of issue?
Hey @bchapuis I think just hit the repo maintainers, but if you want to go full hardcore its usually EMO (emo (at) eclipse.org), more contacts can be found here https://www.eclipse.org/org/foundation/contact.php
Thanks for you contribution! ECA is green as well.
🤦 I'll double check files contents with the pre 1.2.x version. Also there should be no dependency between core and epsg I think, or it should be a provided / optional / test one.