LazyCRS has incorrect OGC CRS WKT <geographic_crs_keyword>

locationtech / rasterframes

Geospatial Raster support for Spark DataFrames

http://rasterframes.io

Apache License 2.0

243 stars 46 forks source link

LazyCRS has incorrect OGC CRS WKT <geographic_crs_keyword> #438

Closed vpipkt closed 4 years ago

vpipkt commented 4 years ago

Pattern matching fails on the following legal values for OGC WKT:

GEOGCRS See sec 8.1 of spec
GEOGRAPHICCRS - sec 8.1
PROJCRS See sec 9.1
PROJECTEDCRS See sec 9.1

Arguable if this should support <geodetic crs keyword> values GEODCRS | GEODETICCRS. I'm not sure if the downstream libraries do.

vpipkt commented 4 years ago

Hmm i may be mixing things up with different versions of the spec. Looking deeper into it now.

vpipkt commented 4 years ago

Some background based on more research.

RasterFrames CRS WKT parsing relies on the geotrellis proj4 module, which it seems is a port of a port...

The pyrasterframes dependencies currently resolve to a proj version 6 which has much more robust support for:

specifying projection by urn
latest versions of WKT spec

Propose for now clarifying the use of "WKT1" in the error messaging.

vpipkt commented 4 years ago

Probably should mark this as won't fix and perhaps defer to some other discussion about plans around LocationTech proj4j and GeoTrellis's proj4 module. It would be awesome to be able to use the 2015 or 2018 standards.

pomadchin commented 4 years ago

hey @vpipkt you're welcome to create PRs / open discussions in the proj4j locationtech repo: we're proj4 maintainers (Eugene & me)! We'll try to merge & release whatever is important for you ASAP.

Just co clarify things, geotrellis/proj4 is more a thin Scala wrapper / convenience layer between locationtech/proj4 and GeoTrellis, this about doc is a bit outdated, thanks for catching that. It no longer contains locationtech/proj4 files, GeoTrellis depends on locationtech/proj4(as a binary dep) since some 2.x version. More over locationtech/proj4 project is in fact the old geotrellis/proj4 library (we just moved this code into a separate repo during / a lil bit after the Bonn OSGEO CodeSprint in 2018).

pomadchin commented 4 years ago

Also both https://github.com/locationtech/proj4j/issues/23 and https://github.com/locationtech/proj4j/issues/49 are in our backlog, but I don't know when we'll have time to dive into them.

vpipkt commented 4 years ago

@pomadchin Sorry for the slow response. Very interesting. I think we can close this issue in favor of the related issues already cited here.