Some code smell reduction

[matteobaccan]

Hi

I have analyzed the source code with a static analyzer and I have removed some code smell

• Missing override
• Removed unused parameters
• Unused assignment
• Boolean literals redundant
• Unused import
• Catches combined
• Return redundant

All the best matteo baccan

[matteobaccan]

Sorry for the wrong commit. I have signed the commit after the first pull request

[codecov-commenter]

Codecov Report

Merging #202 (ef060eb) into master (e775eaa) will decrease coverage by 0.00%. The diff coverage is 25.00%.

@@             Coverage Diff              @@
##             master     #202      +/-   ##
============================================
- Coverage     75.92%   75.91%   -0.01%     
+ Complexity     1112     1110       -2     
============================================
  Files            59       59              
  Lines          3825     3811      -14     
  Branches        775      774       -1     
============================================
- Hits           2904     2893      -11     
+ Misses          644      639       -5     
- Partials        277      279       +2     

Impacted Files	Coverage Δ	Complexity Δ
...a/org/locationtech/spatial4j/io/GeoJSONReader.java	64.40% <0.00%> (+0.71%)	43.00 <0.00> (ø)
...va/org/locationtech/spatial4j/io/GeohashUtils.java	88.46% <ø> (-0.15%)	28.00 <0.00> (ø)
...org/locationtech/spatial4j/io/PolyshapeReader.java	81.30% <0.00%> (+1.49%)	20.00 <0.00> (ø)
...ocationtech/spatial4j/io/jts/JtsGeoJSONWriter.java	76.59% <ø> (+0.06%)	21.00 <0.00> (ø)
...ationtech/spatial4j/io/jts/JtsPolyshapeWriter.java	82.60% <ø> (+0.25%)	15.00 <0.00> (ø)
...a/org/locationtech/spatial4j/shape/impl/Range.java	0.00% <ø> (ø)	0.00 <0.00> (ø)
...cationtech/spatial4j/shape/impl/RectangleImpl.java	92.76% <ø> (ø)	87.00 <0.00> (ø)
...locationtech/spatial4j/distance/DistanceUtils.java	69.75% <50.00%> (ø)	50.00 <0.00> (ø)
.../locationtech/spatial4j/shape/jts/JtsGeometry.java	77.03% <0.00%> (-1.07%)	80.00% <0.00%> (-2.00%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e775eaa...ef060eb. Read the comment docs.

[dsmiley]

Thanks! You just need to digitally sign the Eclipse Contributor Agreement, which is a one-time thing for all of Eclipse. I recently heard git "-S" is no longer a requirement at ECA. I will remove that step from CONTRIBUTING.md

[matteobaccan]

Hi

I have digitally signed the ECA

Tell me if it's OK

al the best matteo baccan

[dsmiley]

Not yet anyway... click "Details" link on the PR checks for eclipsefdn/eca.

[matteobaccan]

I have clicked, now it's ok :) Thank you for the support