search

locationtech / udig-platform

uDig parent project containing all core components. More plugins can be found in community repos: http://github.com/uDig-Community
http://udig.refractions.net
189 stars 133 forks source link

MapEditor uses same internal EditorID like MapEditorWithPalette #384

Closed fgdrf closed 4 years ago

fgdrf commented 4 years ago

see MapEditorWithPalette.ID and MapEditor.ID.

org.locationtech.udig.project.ui.internal.MapEditor.ID is "org.locationtech.udig.project.ui.mapEditor" and doesn' match the id used in Extension-point

<extension
         point="org.eclipse.ui.editors">
      <editor
            class="org.locationtech.udig.project.ui.internal.MapEditor"
            contributorClass="org.locationtech.udig.project.ui.internal.MapEditorActionBarContributor"
            default="false"
            icon="icons/obj16/map_obj.gif"
            id="org.locationtech.udig.project.ui.mapEditorOld"
            name="%mapEditor.name">
      </editor>

org.locationtech.udig.project.ui.internal.MapEditorWithPalette.ID has the same value which matches the id in extension point (project.edit plugin):

Question: How can I configure uDig to use "old" Editor without Palette for Actions? How is EditorInput associated with MapEditor?

fgdrf commented 4 years ago

A : EditorInput is defined with following extension, where editorPartID should match the editor id attribute mentioned above

<extension
         point="org.locationtech.udig.project.ui.editorInputs">
      <editorInput
            editorPartID="org.locationtech.udig.project.ui.mapEditor"
            projectElement="org.locationtech.udig.project.internal.impl.MapImpl"
            class="org.locationtech.udig.project.ui.internal.MapEditorInput"
            name="org.locationtech.udig.project.internal.ui.mapEditorInput"/>
fgdrf commented 4 years ago

Strange thing : if using editorPartID="org.locationtech.udig.project.ui.mapEditorOld" rather than editorPartID="org.locationtech.udig.project.ui.mapEditor" than the opened Map doesn't show the Actions as EditorActions anymore. IMHO Actions should be visible (Editor Toolbar vs. Pallete) independently from the Map Editor that should be used