Browse functionality - Githubissues

locdb / locdb-frend

Fr(ont-)end for the Linked Open Citation Database.

https://locdb.github.io

GNU General Public License v3.0

6 stars 2 forks source link

Browse functionality #411

Open LauraErhard opened 5 years ago

LauraErhard commented 5 years ago

I noticed that if I browse I only see 10 results at a time (even though I said filter for 40 results) and there is no possibility to show all. Is there a bug preventing more results to show?

On top of that it would be really nice if we had the same filters as for the suggestion search (Source, Type, Contained, Year)

lgalke commented 5 years ago

Filtering is added. The browse component has no display limit, and therefore no 'Show more' button. We display everything that is supplied by the back-end.

lgalke commented 5 years ago

Please test again, if there are really too few resources returned. Please also consider the number of results limit, which is per default at 20.

LauraErhard commented 5 years ago

The filters are working fine, thanks for that.

Are you sure about the 20 search results. I just tried different searches and I can't believe that even for a search with just and I get back exactly 10 results. It seems to me, that the default is somehow at 10 and even changing the number doesn't change anything.

I noticed something curious too. Normally the internal suggestions don't have a source in yellow at the end. But now I see them sometimes (in dev): browse Is this just an anomaly from the dev version and shouldn't happen in the prod? Or is there a bug somewhere?

lgalke commented 5 years ago

It comes from migrated suggestions. The source property is taken as is and saved. Would you prefer to have it removed instead?

About the spurious 10 limit @anlausch, do you have an idea? I'm calling the internalSuggestions API with the user-defined number as threshold.

kleinann commented 5 years ago

I noticed something similar today: The resource "Democracy in America" is found when I search with the exact title, but it's not in the list when I just search for "america". It actually was before I changed its resource type from "Monograph" to "Book set" - but that can probably not be the reason for disappearing.

kleinann commented 5 years ago

Not necessarily for the workshop, but in general: Could we make identifiers searchable?

lgalke commented 5 years ago

The resource "Democracy in America" is found when I search with the exact title, but it's not in the list when I just search for "america".

I'm just guessing: maybe the comparison is case-sensitive.