locdb / locdb-frend

Fr(ont-)end for the Linked Open Citation Database.
https://locdb.github.io
GNU General Public License v3.0
6 stars 2 forks source link

Entries in electronic resources (prod) #444

Open LauraErhard opened 5 years ago

LauraErhard commented 5 years ago

Today I noticed, that there are a lot of new entries in the electronic resource list, e.g.: 2019-02-12 Is there a problem with the external / valid settings again? I don't know if there is any correlation but yesterday we set a few journal articles to Done, but I think some of these entries were already there the day before that. @abdelqader-mohammad would you please check these entries out.

lgalke commented 5 years ago

Deployed including the fix 892c33e on dev. As there were other recent updates, please make sure that dev is running properly before we push the changes to production.

LauraErhard commented 5 years ago

I'm testing everything on dev right now. While editing the boxes in the scan view I can't delete more than one box at a time. If I do, I get a 500 internal server error. Adding and adjusting more than one box is very smooth and I didn't run into problems there. EDIT: The first box I deleted is really deleted and every box after that gets a 500 internal server error.

lgalke commented 5 years ago

Thanks @LauraErhard , CC @chah3d could you have a look regarding the deletion please?

chah3d commented 5 years ago

As far as i could test it, processing the delete requests asynchronously does the trick (accf57122f81df6959726b6462517a5a1eb91b2c). If they still fail there will be a few retries.

LauraErhard commented 5 years ago

Thanks for your quick work!

abdelqader-mohammad commented 5 years ago

Thank you for your quick response and help, @lgalke and @chah3d. @LauraErhard can you test the system? Let us know if you have new issues

LauraErhard commented 5 years ago

I just tested the deleting again. If I delete two boxes and click save and exit I get the error 500 for the second box again, but after clicking okay it looks like it was deleted anyway. But after refreshing the page I see the box again. Similarly if I delete two boxes and click save I get the error again and it looks like both boxes were deleted, but if I go back with cancel only one box got deleted. So there is still an issue or where @chah3d changes not yet implemented

LauraErhard commented 5 years ago

@abdelqader-mohammad the scan view was the major change in the dev system right? I linked a few different references and everything seems in order. The issues #437, #442, #439 are still there, but I think there was nothing done on them, so logically they still exist. Are there any other particular changes I forgot about?

abdelqader-mohammad commented 5 years ago

@LauraErhard For issue #442, we fixed the problem of duplicated forms. The error that still exists needs action from the backend. For #437 and #439 I want to check them. Maybe @chah3d or @lgalke have a fast comment for those issues.

lgalke commented 5 years ago

it looks like it was deleted anyway. But after refreshing the page I see the box again.

We need to make sure that we update the view only if the back-end call succeeded. Maybe this is not properly reflected in this case.

@abdelqader-mohammad I've put my fast comments in the other issues.

abdelqader-mohammad commented 5 years ago

@lgalke Thank you for your comments :) So, the mentioned issues need action from the other partners.

chah3d commented 5 years ago

I just tested the deleting again. If I delete two boxes and click save and exit I get the error 500 for the second box again, but after clicking okay it looks like it was deleted anyway. But after refreshing the page I see the box again. Similarly if I delete two boxes and click save I get the error again and it looks like both boxes were deleted, but if I go back with cancel only one box got deleted. So there is still an issue or where @chah3d changes not yet implemented

The changes regarding the bounding box editing are now on the dev.

abdelqader-mohammad commented 5 years ago

I tried to delete 3 boxes. It works well. @LauraErhard please test it

LauraErhard commented 5 years ago

I can confirm, the deleting runs smoothly now. Thanks everyone!