Open LauraErhard opened 5 years ago
Deployed including the fix 892c33e on dev. As there were other recent updates, please make sure that dev is running properly before we push the changes to production.
I'm testing everything on dev right now. While editing the boxes in the scan view I can't delete more than one box at a time. If I do, I get a 500 internal server error. Adding and adjusting more than one box is very smooth and I didn't run into problems there. EDIT: The first box I deleted is really deleted and every box after that gets a 500 internal server error.
Thanks @LauraErhard , CC @chah3d could you have a look regarding the deletion please?
As far as i could test it, processing the delete requests asynchronously does the trick (accf57122f81df6959726b6462517a5a1eb91b2c). If they still fail there will be a few retries.
Thanks for your quick work!
Thank you for your quick response and help, @lgalke and @chah3d. @LauraErhard can you test the system? Let us know if you have new issues
I just tested the deleting again.
If I delete two boxes and click save and exit
I get the error 500 for the second box again, but after clicking okay it looks like it was deleted anyway. But after refreshing the page I see the box again.
Similarly if I delete two boxes and click save
I get the error again and it looks like both boxes were deleted, but if I go back with cancel
only one box got deleted.
So there is still an issue or where @chah3d changes not yet implemented
@abdelqader-mohammad the scan view was the major change in the dev system right? I linked a few different references and everything seems in order. The issues #437, #442, #439 are still there, but I think there was nothing done on them, so logically they still exist. Are there any other particular changes I forgot about?
@LauraErhard For issue #442, we fixed the problem of duplicated forms. The error that still exists needs action from the backend. For #437 and #439 I want to check them. Maybe @chah3d or @lgalke have a fast comment for those issues.
it looks like it was deleted anyway. But after refreshing the page I see the box again.
We need to make sure that we update the view only if the back-end call succeeded. Maybe this is not properly reflected in this case.
@abdelqader-mohammad I've put my fast comments in the other issues.
@lgalke Thank you for your comments :) So, the mentioned issues need action from the other partners.
I just tested the deleting again. If I delete two boxes and click
save and exit
I get the error 500 for the second box again, but after clicking okay it looks like it was deleted anyway. But after refreshing the page I see the box again. Similarly if I delete two boxes and clicksave
I get the error again and it looks like both boxes were deleted, but if I go back withcancel
only one box got deleted. So there is still an issue or where @chah3d changes not yet implemented
The changes regarding the bounding box editing are now on the dev.
I tried to delete 3 boxes. It works well. @LauraErhard please test it
I can confirm, the deleting runs smoothly now. Thanks everyone!
Today I noticed, that there are a lot of new entries in the
electronic resource
list, e.g.: Is there a problem with theexternal
/valid
settings again? I don't know if there is any correlation but yesterday we set a few journal articles toDone
, but I think some of these entries were already there the day before that. @abdelqader-mohammad would you please check these entries out.