search

lochmueller / calendarize

📆 Best TYPO3 Calendar ever 📆
http://typo3.org/extensions/repository/view/calendarize
74 stars 84 forks source link

Question: will the routeEnhancers work properly without {calendarize_event_label} #640

Closed bavarianbytes closed 2 years ago

bavarianbytes commented 2 years ago

If i remove /{calendarize_event_label} from the first routePath to get shorter URLs (detail view is on its own page, so it has a certain slug), everything seems to work. But is that a good idea or are there any issues i don't see?

      - routePath: '/{index}'
        _controller: 'Calendar::detail'
      - routePath: '/{calendarize_year_label}/{year}'
        _controller: 'Calendar::year'
      - routePath: '/{calendarize_quarter_label}/{quarter}'
        _controller: 'Calendar::quarter'
      - routePath: '/{calendarize_month_label}/{year}/{month}'
        _controller: 'Calendar::month'
      - routePath: '/{calendarize_week_label}/{year}/{week}'
        _controller: 'Calendar::week'
      - routePath: '/{calendarize_day_label}/{year}/{month}/{day}'
        _controller: 'Calendar::day'
      - routePath: '/{calendarize_result_page_label}/{currentPage}'
        _controller: 'Calendar::result'
      - routePath: '/{calendarize_page_label}/{currentPage}'
        _controller: 'Calendar::list'
okmiim commented 2 years ago

Hi @bavarianbytes, This should be fine. I believe it avoided conflicts in mixed ListDetail configurations in past versions. This usage/convention has been carried on for the last several major versions.