lochmueller / calendarize

📆 Best TYPO3 Calendar ever 📆
http://typo3.org/extensions/repository/view/calendarize
74 stars 85 forks source link

Search result pagination is not working #665

Closed okmiim closed 2 years ago

okmiim commented 2 years ago

The current implementation for pagination does not work on search results.

The search form uses a POST request. The pagination links are GET links and don't submit the filters when the page changes.

Possible solutions

lochmueller commented 2 years ago

Hey @okmiim

I integrated the JS logic from indexed search and use the form field as base (hidden via Boostrap d-none class).

Notice: I set the page "1" as default value for the form. As result the Pagination could use to navigate the results: https://jetzt.fruit-lab.de/ (Search for a 2 years range from now and look for 'Dart') BUT, when you use the form itself (e.g. change search parameters) you will see the first page again. If I use the "currentPage" as default for the form input, you would see the "currentPage" of your last search and I think it is more useful to see the first page, after setting some new search input by the user.

Please check the solution and send me some feedback... Would be cool.

Regards, Tim

lochmueller commented 2 years ago

Notice: Small follow-up cleanup, so the JS is only used, if the search is executed (not in the initial displayed view)

lochmueller commented 2 years ago

Hey @okmiim I will close this issue. If there are follow-ups/cleanups feel free to add this in the code. Thanks for your detailed preparation. Best regards, Tim