lochmueller / calendarize

📆 Best TYPO3 Calendar ever 📆
http://typo3.org/extensions/repository/view/calendarize
75 stars 84 forks source link

PHP8 fix / check if array value is set #727

Closed dennismetz closed 1 year ago

lochmueller commented 1 year ago

Thanks @dennismetz for the fix.

Next time, feel free to use the Null Coalescing Operator instead of isset. I will check this for the complete extension shortly and will migrate the isset.

Regards, Tim

okmiim commented 1 year ago

Actually this introduced an other bug. In the case $params['row']['uid'] is not set, it does not return early and continues with the rest of the function. So either a) !isset($params['row']['uid']) || !MathUtility::canBeInterpretedAsInteger($params['row']['uid']) b) !MathUtility::canBeInterpretedAsInteger($params['row']['uid'] ?? '') would be correct here.

lochmueller commented 1 year ago

Thanks for fix to Null Coalescing Operator @okmiim Regards, Tim