Open ftrojahn opened 7 months ago
Hi @ftrojahn,
one big painpoint with the ICS import is that is is only an "import" (add + update) and not really a "synchronization" (... + delete). I been thinking/planning (for a long time) to do a new implementation of the ICS handling, but did not get around to that.
The modification of specific instance of a recurring series in iCalendar is actually reflected by the RECURRENCE-ID
and not the . The SEQUENCE
RECURRENCE-ID
value contains the date when original recurrence instance would occur, which is "overwritten".
The SEQUENCE
number is just "sequence of revisions" and not (really) relevant for recurring series.
You could handle the import of specific recurring instances as follows:
handling=exclude
with the recurrence dateA hacky way to get rid of non-existing ics-events:
Regards
Hello, we maintain an instance with more than 500 domains. So, there are a lot of ics imports (see verdigado/calendarize_external).
During integration of calendarize we noticed
SEQUENCE
key in ics files is not respected.This leads to recurring events, which will be created (or old ones overwritten): but without the frequency ... resulting in missing events.
Only workaround for now is, in the source ics calendar: deleting the recurring event (which had a calendar exception) and recreating the recurring event from scratch, which is not always possible (not all users own that calendar they export from).
I debugged it like this:
UID
and differentSEQUENCE
like 0 and 1.SEQUENCE:0
has theRRULE
=> frequency is set for the importid.SEQUENCE:1
has noRRULE
, but same UID => frequency is unset.Invalid frequency="{frequency}" in RRULE
errorsSEQUENCE:11
, but no other event with the sameUID
/ importIdIMHO we could fix this by attaching the sequence id to the importid like here: https://github.com/lochmueller/calendarize/compare/master...verdigado:calendarize:add-sequenceid-to-importid (no PR, just asking)
But this creates two other problems:
That is due to: old imported events will not be deleted on ics import, if deleted in ics source. See #620 too.
So we would have to deal with finding all "old" importId events which must be deleted, if we have a new import with importId+sequenceid. ATM I see at least no slot/eventlistener where I can hook in to do this.
My test calendar link contains both of the above mentioned recurring events.
Any idea? Thanx anyway for this great extension! Falko