search

lochmueller / focuspoint

🌅 Smartest TYPO3 Crop Tool ever 🌅
http://typo3.org/extensions/repository/view/focuspoint
22 stars 23 forks source link

y-axis centered instead of position #74

Closed SimonWpt closed 4 years ago

SimonWpt commented 4 years ago 
TYPO3 9.5.14
composer req lochmueller/focuspoint:dev-master
ddev version v1.13.1

When setting a focal point, the y-axis is centered instead of focal position.

Backend Setting focal1

Command <fp:image image="{image}" width="1000c" height="400c" realCrop="true"/>

Frontend View focal2

SimonWpt commented 4 years ago

Any chance, that this issue will be fixed soon?

lochmueller commented 4 years ago

Hey @SimonWpt there is no fixed time scheduler for my open source work. Sorry... I try to check this in the next days. Feel free to support me... Regards, Tim

lochmueller commented 4 years ago

I checked this problem. The reason for this problem are the "c" values for with and height. There is no reason for this, beccause in your layout you know the dimension of the image and you are using focuspoint to get the right position. Just use regular integer values for height and width and recheck your test szenario.

Thank you.

SimonWpt commented 4 years ago

Hello Tim,

thank you for checking my problem. I am a little bit confused, because your examples use the "c" for cropping:

https://github.com/lochmueller/focuspoint#fluid-template-example

Is "c" only available for realCrop="false"?

Thank you again for your effort.

lochmueller commented 4 years ago

I think the example is wrong. The usecase of focuspoint is, that you know the dimension and size and focuspoint know the best psoition. The ViewHelper always crop the best position (in realCrop mode) and never crop without real crop (because the FE JS lib do it). So the "c" is not needed.